Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password Login Fixes #716

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Password Login Fixes #716

merged 3 commits into from
Oct 11, 2024

Conversation

MelissaAutumn
Copy link
Member

Part of #120

This allows the password flow to create a new subscriber on first-login. But only first-login. (Well when there's no subscribers.)

Input wanted: Do we need to put this behaviour behind a env flag for extra security?

I discovered a fun bug with schedule creation/updates that causes it to fail because times are in UTC and 14:00 as a start-time is bigger than 0:00 as an end time. So we now collect timezones for schedules, and store them. (That'll be handy later!) We don't do anything else with them right now.

@MelissaAutumn MelissaAutumn self-assigned this Oct 8, 2024
@malini
Copy link
Contributor

malini commented Oct 8, 2024

+1 for hiding this behind an env flag! Best to isolate this behaviour from prod as much as possible

@MelissaAutumn
Copy link
Member Author

+1 for hiding this behind an env flag! Best to isolate this behaviour from prod as much as possible

Sounds good, it's only active with password auth and not fxa as that will always create new users.

@MelissaAutumn
Copy link
Member Author

And added the env gate.

Copy link
Collaborator

@devmount devmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and looks like it works without any issues! Thank you!

@devmount devmount merged commit e907487 into main Oct 11, 2024
4 checks passed
@devmount devmount deleted the features/120-login branch October 11, 2024 21:09
MelissaAutumn added a commit that referenced this pull request Oct 15, 2024
* Adjust /token to create a user if one doesn't exist. Only works with password auth.

* Add timezone to schedule for future-use (because we're collecting it right now..)

* Gate the first time registration for password auth behind an env var.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants