Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encrypted message subject should use standard "[...]" #8011

Closed
2 tasks done
dkg opened this issue Jul 13, 2024 · 0 comments · Fixed by #8014
Closed
2 tasks done

encrypted message subject should use standard "[...]" #8011

dkg opened this issue Jul 13, 2024 · 0 comments · Fixed by #8014
Assignees
Labels
type: bug Something is causing incorrect behavior or errors

Comments

@dkg
Copy link

dkg commented Jul 13, 2024

Checklist

  • I have used the search function to see if someone else has already submitted the same bug report.
  • I will describe the problem with as much detail as possible.

App version

git head (123ad8c)

Where did you get the app from?

Other

Android version

fetched from source

Device model

No response

Steps to reproduce

  1. send an encrypted message with the subject header protected
  2. look at raw message sent on wire
  3. external Subject header field shows "Encrypted message", or some localized variant of it

Expected behavior

It would be better to use the non-localized string [...] as recommended in the default HCPs in draft-ietf-lamps-header-protection.

Using a localized string leaks the user's locale to any network operator that can view the message, which reduces size of the anonymity set. Furthermore, using a specific string unique to thunderbird-android (or k-9) leaks information about what e-mail client the user is using. This not only reduces the size of the anonymity set further, it also potentially leaks information that an adversary could use for targeted attacks based on known flaws with specific MUAs.

Finally, a subject line of "Encrypted message" (in whatever language) can be accidentally copied into a reply message, which itself is not encrypted. So the string "Encrypted message" isn't even a reliable signal to the end user who receives such a message.

Actual behavior

the external Subject header field for an encrypted message shows "Encrypted message" or some other localized string.

Logs

No response

@dkg dkg added type: bug Something is causing incorrect behavior or errors unconfirmed Newly reported issues awaiting triage or confirmation labels Jul 13, 2024
dkg added a commit to deltachat/chatmail that referenced this issue Jul 13, 2024
These additional subjects were extracted from the thunderbird-android
source (which is inherited from k-9).

The extraction was done with:

```
git clone https://github.com/thunderbird/thunderbird-android/
cd thunderbird-android/legacy/ui/legacy/src/main/res
grep string\ name=\"encrypted_subject values-*/strings.xml | cut -f2 -d'>' | cut -f1 -d'<' | sort -u | sed -e 's/^/    "/' -e 's/$/",/'
```

(i did need to clean up one line's escaping to pass the linter's
expectations)

See also thunderbird/thunderbird-android#8011
dkg added a commit to deltachat/chatmail that referenced this issue Jul 15, 2024
These additional subjects were extracted from the thunderbird-android
source (which is inherited from k-9).

The extraction was done with:

```
git clone https://github.com/thunderbird/thunderbird-android/
cd thunderbird-android/legacy/ui/legacy/src/main/res
grep string\ name=\"encrypted_subject values-*/strings.xml | cut -f2 -d'>' | cut -f1 -d'<' | sort -u | sed -e 's/^/    "/' -e 's/$/",/'
```

(i did need to clean up one line's escaping to pass the linter's
expectations)

See also thunderbird/thunderbird-android#8011
@cketti cketti self-assigned this Jul 15, 2024
@cketti cketti removed the unconfirmed Newly reported issues awaiting triage or confirmation label Jul 15, 2024
hpk42 pushed a commit to deltachat/chatmail that referenced this issue Jul 17, 2024
These additional subjects were extracted from the thunderbird-android
source (which is inherited from k-9).

The extraction was done with:

```
git clone https://github.com/thunderbird/thunderbird-android/
cd thunderbird-android/legacy/ui/legacy/src/main/res
grep string\ name=\"encrypted_subject values-*/strings.xml | cut -f2 -d'>' | cut -f1 -d'<' | sort -u | sed -e 's/^/    "/' -e 's/$/",/'
```

(i did need to clean up one line's escaping to pass the linter's
expectations)

See also thunderbird/thunderbird-android#8011
hpk42 pushed a commit to deltachat/chatmail that referenced this issue Jul 28, 2024
These additional subjects were extracted from the thunderbird-android
source (which is inherited from k-9).

The extraction was done with:

```
git clone https://github.com/thunderbird/thunderbird-android/
cd thunderbird-android/legacy/ui/legacy/src/main/res
grep string\ name=\"encrypted_subject values-*/strings.xml | cut -f2 -d'>' | cut -f1 -d'<' | sort -u | sed -e 's/^/    "/' -e 's/$/",/'
```

(i did need to clean up one line's escaping to pass the linter's
expectations)

See also thunderbird/thunderbird-android#8011
hpk42 pushed a commit to deltachat/chatmail that referenced this issue Jul 28, 2024
These additional subjects were extracted from the thunderbird-android
source (which is inherited from k-9).

The extraction was done with:

```
git clone https://github.com/thunderbird/thunderbird-android/
cd thunderbird-android/legacy/ui/legacy/src/main/res
grep string\ name=\"encrypted_subject values-*/strings.xml | cut -f2 -d'>' | cut -f1 -d'<' | sort -u | sed -e 's/^/    "/' -e 's/$/",/'
```

(i did need to clean up one line's escaping to pass the linter's
expectations)

See also thunderbird/thunderbird-android#8011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something is causing incorrect behavior or errors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants