-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency cleanup #8001
Dependency cleanup #8001
Conversation
implementation(libs.timber) | ||
|
||
testImplementation(libs.robolectric) | ||
testImplementation(libs.robolectric.shadows) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API surface of org.robolectric:shadows-framework
is part of org.robolectric:robolectric
's API surface. We'll never use the shadows framework independently of Robolectric. Why include a direct dependency?
@@ -3,9 +3,13 @@ plugins { | |||
} | |||
|
|||
dependencies { | |||
api(projects.app.core) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why make :app:core
part of :feature:widget:message-list
's API surface? Ideally a feature module would never make any of its dependencies part of its public API.
implementation(projects.app.ui.legacy) | ||
implementation(projects.app.core) | ||
implementation(projects.core.ui.legacy.designsystem) | ||
implementation(projects.mail.common) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like this should be tackled once we actually work on removing the dependency on :app:core
. Chances are that will also get rid of the :mail:common
dependency. It doesn't feel like adding a direct dependency on :mail:common
now while also keeping the :app:core
dependency adds any value.
|
||
implementation(libs.preferencex) | ||
api(libs.preferencex) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why make this particular library an API dependency?
api(projects.app.core) | ||
api(projects.app.ui.base) | ||
api(projects.app.ui.legacy) | ||
api(projects.mail.common) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dramatically increases the API surface of the feature module. Why?
This is a partial change to the dependencies setup and not complete. So there are The rest will be continued when there is more time available. |
As this is not crucial at the moment, I'll close this and continue at a later point |
This is a first step to cleanup the project dependencies and declare transient dependencies better.