Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added content description for star button #8246

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

Yogeshjindal
Copy link
Contributor

@Yogeshjindal Yogeshjindal commented Oct 7, 2024

Fixes #8218
Added description for the star button.

Expected behavior
TalkBack says the purpose of the button, such as "star" or "favorite".

Old Actual behavior
TalkBack says "unlabeled button" and does not convey the purpose of the button.

New Actual behavior
TalkBack says the purpose of the button, such as "star" .

@wmontwe wmontwe self-assigned this Oct 7, 2024
Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Please add the new string under values-en instead of values-hy as English is the default language for translations in the project.

@Yogeshjindal
Copy link
Contributor Author

Thanks for reviewing , the asked changes had been made.

@kewisch
Copy link
Member

kewisch commented Oct 7, 2024

@Yogeshjindal Thanks for the quick changes! The file this needs to go in to is actually legacy/ui/base/src/main/res/values/strings.xml which holds the en-US base strings. Would you mind updating your PR once more? We'd love to get this into beta 2 which we're spinning later today, if you don't have time beforehand we can make the update.

@kewisch
Copy link
Member

kewisch commented Oct 7, 2024

@Yogeshjindal If you could also look at the linting failures please I'd appreciate.

@wmontwe wmontwe self-requested a review October 7, 2024 16:28
@wmontwe wmontwe merged commit b37ab4d into thunderbird:main Oct 7, 2024
2 checks passed
@Yogeshjindal
Copy link
Contributor Author

@Yogeshjindal If you could also look at the linting failures please I'd appreciate.

Sure Sir, I will look into that.
Thanks for merging the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Star button on message reading screen has no accessible name
3 participants