Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approval status and LGT* tags not properly synchronized #990

Open
1 task done
s3nt3 opened this issue Aug 8, 2022 · 3 comments
Open
1 task done

Approval status and LGT* tags not properly synchronized #990

s3nt3 opened this issue Aug 8, 2022 · 3 comments
Labels
lifecycle/rotten type/bug Categorizes issue or PR as related to a bug.

Comments

@s3nt3
Copy link

s3nt3 commented Aug 8, 2022

Bug Report

  • I have searched the issues of this repository and believe that this is not a duplicate.

Related link

Steps to reproduce(Optional)

What is expected?

If the reviewer start a new review converstaion or submit a new commit, the approval should be dismissed.
If the approval is dismissed, the LGT* label should be deleted.

What is actually happening?

When a reviewer starts a new review conversation, the approval status does not change. The LGT* label also does not change when an approval is dismissed.

@s3nt3 s3nt3 added the type/bug Categorizes issue or PR as related to a bug. label Aug 8, 2022
@s3nt3
Copy link
Author

s3nt3 commented Aug 8, 2022

/cc @wuhuizuo

@ti-chi-bot
Copy link
Member

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-community-infra or Mini256.
/lifecycle stale

@ti-chi-bot
Copy link
Member

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-community-infra or Mini256.
/lifecycle rotten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten type/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants