Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: PoC to verify if unresolved conversations will block merging #523

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

s3nt3
Copy link
Contributor

@s3nt3 s3nt3 commented Aug 8, 2022

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please add a release note, or a 'None' if it is not needed.

@mini-bot
Copy link
Contributor

mini-bot commented Aug 8, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • wuhuizuo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@mini-bot
Copy link
Contributor

mini-bot commented Aug 8, 2022

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

@mini-bot
Copy link
Contributor

mini-bot commented Aug 8, 2022

@s3nt3: Thanks for your contribution, but this is just a code repository for testing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@mini-bot
Copy link
Contributor

mini-bot commented Aug 8, 2022

Hi @s3nt3. Thanks for your PR.

I'm waiting for a ti-community-infra member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mini-bot mini-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 8, 2022
@@ -0,0 +1 @@
this_is_a_poc
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this_is_a_poc
this_is_another_poc

@s3nt3
Copy link
Contributor Author

s3nt3 commented Aug 8, 2022

/cc @wuhuizuo

@mini-bot mini-bot requested a review from wuhuizuo August 8, 2022 06:08
@@ -0,0 +1 @@
this_is_a_poc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should change?

@wuhuizuo wuhuizuo self-requested a review August 8, 2022 06:53
@mini-bot mini-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 8, 2022
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Aug 8, 2022

/merge

@mini-bot
Copy link
Contributor

mini-bot commented Aug 8, 2022

This pull request has been accepted and is ready to merge.

Commit hash: 3962b4d

@mini-bot mini-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 8, 2022
@mini-bot mini-bot merged commit 1808c90 into ti-community-infra:master Aug 8, 2022
@mini-bot mini-bot added this to the v0.1.0 milestone Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution do-not-merge/needs-linked-issue first-time-contributor needs-ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants