-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide USB console by snippets instead of specific board revision #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This snippet is based on zephyr/snippets/cdc-acm-console. Since it's a snippet, it can be used in any application as long as its requirements are met. This makes it more general purpose. Signed-off-by: Stephan Linz <linz@li-pro.net>
Signed-off-by: Stephan Linz <linz@li-pro.net>
- remove the special board revisions '@uartcons' and '@usbcons' - adapt documentation and link to usb-console snippet Signed-off-by: Stephan Linz <linz@li-pro.net>
Signed-off-by: Stephan Linz <linz@li-pro.net>
Signed-off-by: Stephan Linz <linz@li-pro.net>
Signed-off-by: Stephan Linz <linz@li-pro.net>
- remove the special board revisions '@uartcons' and '@usbcons' - adapt documentation and link to usb-console snippet Signed-off-by: Stephan Linz <linz@li-pro.net>
Signed-off-by: Stephan Linz <linz@li-pro.net>
Signed-off-by: Stephan Linz <linz@li-pro.net>
Signed-off-by: Stephan Linz <linz@li-pro.net>
- remove the special board revisions '@uartcons' and '@usbcons' - adapt documentation and link to usb-console snippet Signed-off-by: Stephan Linz <linz@li-pro.net>
Signed-off-by: Stephan Linz <linz@li-pro.net>
Signed-off-by: Stephan Linz <linz@li-pro.net>
Signed-off-by: Stephan Linz <linz@li-pro.net>
- remove the special board revisions '@uartcons' and '@usbcons' - adapt documentation and link to usb-console snippet Signed-off-by: Stephan Linz <linz@li-pro.net>
Signed-off-by: Stephan Linz <linz@li-pro.net>
Signed-off-by: Stephan Linz <linz@li-pro.net>
Signed-off-by: Stephan Linz <linz@li-pro.net>
Signed-off-by: Stephan Linz <linz@li-pro.net>
Signed-off-by: Stephan Linz <linz@li-pro.net>
Signed-off-by: Stephan Linz <linz@li-pro.net>
Signed-off-by: Stephan Linz <linz@li-pro.net>
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
tobiaskaestner
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, many thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #128 – solved is: