-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove deprecated Kconfigs and repair QA pipeline #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates in-tree code for the U-Blox library to use CONFIG_CPP instead of CONFIG_CPLUSPLUS, which is deprecated for more than 3 releases. Signed-off-by: Stephan Linz <linz@li-pro.net>
These clock selection Kconfigs should have been deprecated for more than 2 releases, remove them: - CONFIG_COUNTER_RTC_STM32_CLOCK_SRC - CONFIG_COUNTER_RTC_STM32_CLOCK_LSE Instead favor of device tree secondary domain clock. This fixes following exemplary build error message since Zephyr commit 88c96f7986d408fae48cb538d8144c0aa985edb1: warning: <choice COUNTER_RTC_STM32_CLOCK_SRC> (defined at /.../boards/tiac/magpie_f777ni/Kconfig.defconfig:9) defined without a prompt warning: the default selection COUNTER_RTC_STM32_CLOCK_LSE (undefined) of <choice COUNTER_RTC_STM32_CLOCK_SRC> (defined at /.../boards/tiac/magpie_f777ni/Kconfig.defconfig:9) is not contained in the choice error: Aborting due to Kconfig warnings Signed-off-by: Stephan Linz <linz@li-pro.net>
The following Kconfigs have been deprecated for more than 2 releases, remove them: - CONFIG_MINIMAL_LIBC_MALLOC Instead the new generic Kconfigs will used: - CONFIG_COMMON_LIBC_MALLOC This fixes following exemplary build error message since Zephyr commit c22c98e51033379347cd8c681db34cf7afd33e57: /.../workspace/bridle/samples/ubx_gnss/prj.conf:31: warning: attempt to assign the value 'n' to the undefined symbol MINIMAL_LIBC_MALLOC error: Aborting due to Kconfig warnings Signed-off-by: Stephan Linz <linz@li-pro.net>
The documentation still shows the outdated board names. These have now been changed to the new HW model v2 board terminology. Signed-off-by: Stephan Linz <linz@li-pro.net>
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
tobiaskaestner
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Zephyr upstream v3.7.0-rc1 the following Kconfigs have been removed (deprecated for more than 2 releases):
CONFIG_MINIMAL_LIBC_MALLOC
(replaced byCONFIG_COMMON_LIBC_MALLOC
)CONFIG_COUNTER_RTC_STM32_CLOCK_SRC
CONFIG_COUNTER_RTC_STM32_CLOCK_LSE
(instead favor of device tree secondary domain clock)Remove them in different configuration files of: