Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated Kconfigs and repair QA pipeline #237

Merged
merged 4 commits into from
Jun 21, 2024
Merged

remove deprecated Kconfigs and repair QA pipeline #237

merged 4 commits into from
Jun 21, 2024

Conversation

rexut
Copy link
Member

@rexut rexut commented Jun 20, 2024

Since Zephyr upstream v3.7.0-rc1 the following Kconfigs have been removed (deprecated for more than 2 releases):

  • CONFIG_MINIMAL_LIBC_MALLOC (replaced by CONFIG_COMMON_LIBC_MALLOC)
  • CONFIG_COUNTER_RTC_STM32_CLOCK_SRC
  • CONFIG_COUNTER_RTC_STM32_CLOCK_LSE (instead favor of device tree secondary domain clock)

Remove them in different configuration files of:

  • board "TiaC Magpie F777NI"
  • sample "Ubxlib GNSS Sample"

This commit updates in-tree code for the U-Blox library to use
CONFIG_CPP instead of CONFIG_CPLUSPLUS, which is deprecated for
more than 3 releases.

Signed-off-by: Stephan Linz <linz@li-pro.net>
These clock selection Kconfigs should have been deprecated for
more than 2 releases, remove them:

- CONFIG_COUNTER_RTC_STM32_CLOCK_SRC
- CONFIG_COUNTER_RTC_STM32_CLOCK_LSE

Instead favor of device tree secondary domain clock.

This fixes following exemplary build error message since Zephyr
commit 88c96f7986d408fae48cb538d8144c0aa985edb1:

    warning: <choice COUNTER_RTC_STM32_CLOCK_SRC>
    (defined at /.../boards/tiac/magpie_f777ni/Kconfig.defconfig:9)
    defined without a prompt

    warning: the default selection COUNTER_RTC_STM32_CLOCK_LSE
    (undefined) of <choice COUNTER_RTC_STM32_CLOCK_SRC>
    (defined at /.../boards/tiac/magpie_f777ni/Kconfig.defconfig:9)
    is not contained in the choice

    error: Aborting due to Kconfig warnings

Signed-off-by: Stephan Linz <linz@li-pro.net>
The following Kconfigs have been deprecated for more than 2
releases, remove them:

- CONFIG_MINIMAL_LIBC_MALLOC

Instead the new generic Kconfigs will used:

- CONFIG_COMMON_LIBC_MALLOC

This fixes following exemplary build error message since Zephyr
commit c22c98e51033379347cd8c681db34cf7afd33e57:

    /.../workspace/bridle/samples/ubx_gnss/prj.conf:31: warning:
      attempt to assign the value 'n' to the undefined symbol
      MINIMAL_LIBC_MALLOC

    error: Aborting due to Kconfig warnings

Signed-off-by: Stephan Linz <linz@li-pro.net>
The documentation still shows the outdated board names. These have
now been changed to the new HW model v2 board terminology.

Signed-off-by: Stephan Linz <linz@li-pro.net>
Copy link

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

Copy link
Contributor

@tobiaskaestner tobiaskaestner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rexut rexut merged commit 04ca985 into main Jun 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants