Allow skipping commented policy #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yujincheng08
approved these changes
Jul 10, 2024
|
@gooroodev review |
Please double-check what I found in the pull request:
Summary of Proposed Changes
Identified IssuesNo issues were identified in the proposed changes. General ReviewThe proposed changes are straightforward and improve the functionality by allowing the parser to skip commented lines. The code quality and style are consistent with the existing codebase. No major issues were found, and the change is a good addition to the project. -- |
kutemeikito
added a commit
to kutemeikito/KernelSU
that referenced
this pull request
Jul 22, 2024
* 'main' of https://github.com/tiann/KernelSU: build(deps): bump the npm group in /website with 3 updates (tiann#1903) build(deps): bump syn from 2.0.71 to 2.0.72 in /userspace/ksud in the crates group (tiann#1902) Upgrade rustix (tiann#1900) build(deps): bump the npm group in /website with 2 updates (tiann#1899) build(deps): bump the crates group in /userspace/ksud with 3 updates (tiann#1898) build(deps): bump the npm group in /website with 13 updates (tiann#1893) build(deps): bump the crates group in /userspace/ksud with 40 updates (tiann#1894) [skip ci] Group dependabot dependencies (tiann#1892) Upgrade zip (tiann#1891) build(deps): bump io.coil-kt:coil-compose from 2.6.0 to 2.7.0 in /manager (tiann#1888) build(deps): bump org.lsposed.libcxx:libcxx from 27.0.11718014-beta1 to 27.0.12077973 in /manager (tiann#1885) Upgrade deps (tiann#1886) build(deps-dev): bump vitepress from 1.3.0 to 1.3.1 in /website (tiann#1879) build(deps): bump com.google.devtools.ksp from 2.0.0-1.0.22 to 2.0.0-1.0.23 in /manager (tiann#1872) build(deps): bump agp from 8.5.0 to 8.5.1 in /manager (tiann#1873) Allow skipping commented policy (tiann#1870) build(deps): bump rust-embed from 8.4.0 to 8.5.0 in /userspace/ksud (tiann#1869) build(deps): bump clap from 4.5.8 to 4.5.9 in /userspace/ksud (tiann#1868) Setup Android SDK (tiann#1867) Upgrade gradle (tiann#1866) build(deps-dev): bump vitepress from 1.2.3 to 1.3.0 in /website (tiann#1865) Revert "ksud: [Fix] grant root to the shell in debug mode" (tiann#1860) ksud: upgrade zip (tiann#1859) ksud: [Fix] grant root to the shell in debug mode (tiann#1853) build(deps): bump lifecycle from 2.8.1 to 2.8.3 in /manager (tiann#1851) build(deps): bump clap from 4.5.7 to 4.5.8 in /userspace/ksud (tiann#1850) website: fix typo (tiann#1834) build(deps): bump android_logger from 0.13.3 to 0.14.1 in /userspace/ksud (tiann#1830) build(deps): bump log from 0.4.21 to 0.4.22 in /userspace/ksud (tiann#1843) Update resetprop (tiann#1842) throne_tracker: skip iterate if failed to open dir (tiann#1832) Translations update from Hosted Weblate (tiann#1734) build(deps): bump com.google.devtools.ksp from 2.0.0-1.0.21 to 2.0.0-1.0.22 in /manager (tiann#1811) manager: improve grammar in english (tiann#1814) Redirect the Feature Requests issue template tab (tiann#1788) website: fix typo (tiann#1807) build(deps): bump zip from 2.1.2 to 2.1.3 in /userspace/ksud (tiann#1810) build(deps): bump regex from 1.10.4 to 1.10.5 in /userspace/ksud (tiann#1815) build(deps): bump clap from 4.5.4 to 4.5.7 in /userspace/ksud (tiann#1817) build(deps): bump androidx.compose:compose-bom from 2024.05.00 to 2024.06.00 in /manager (tiann#1820) build(deps): bump agp from 8.4.1 to 8.5.0 in /manager (tiann#1824) build(deps): bump lifecycle from 2.8.0 to 2.8.1 in /manager (tiann#1782) website: update translations (tiann#1796) build(deps): bump zip-extensions from 0.6.2 to 0.7.0 in /userspace/ksud (tiann#1798) build(deps): bump zip from 2.1.0 to 2.1.2 in /userspace/ksud (tiann#1799) build(deps-dev): bump vitepress from 1.2.2 to 1.2.3 in /website (tiann#1803) manager: fix update no response when changelog is empty (tiann#1786) Convert devpts domain to ksu_file (tiann#1801) non-GKI:Remove maintainer Coconutat's repositories (tiann#1794) 从非官方支持设备中移除K-Nel-M1721 (tiann#1792) Signed-off-by: Edwiin Kusuma Jaya <kutemeikito0905@gmail.com>
xxmustafacooTR
pushed a commit
to xxmustafacooTR/KernelSU
that referenced
this pull request
Jul 24, 2024
rsuntk
pushed a commit
to rsuntk/KernelSU
that referenced
this pull request
Jul 26, 2024
fukiame
pushed a commit
to TelegramAt25/KernelSU-shukusai
that referenced
this pull request
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.