ARM/VExpressPkg: Remove Hob creation in StandaloneMm. #209
+100
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeviYeoReum
force-pushed
the
ffa_milestone2
branch
2 times, most recently
from
e08b003 to
832fcc1
Compare
LeviYeoReum
force-pushed
the
ffa_milestone2
branch
from
726739c to
eb9df20
Compare
apalos
reviewed
Oct 22, 2024
LeviYeoReum
force-pushed
the
ffa_milestone2
branch
from
eaf67b7 to
b6decc4
Compare
LeviYeoReum
force-pushed
the
ffa_milestone2
branch
from
b6decc4 to
e02bcad
Compare
ArmTransferList is used to pass boot information according to firmware handoff protocol specification [0]. When initializing StandaloneMm, it gets boot information formatted with PHIT_HOB in TransferList. To get boot information from transfer list, add ArmTrnaferLib for StandaloneMm. Signed-off-by: Levi.Yun <yeoreum.yun@arm.com>
apply FF-A feature on UEFI/StandaloneMm. Signed-off-by: Levi Yun <yeoreum.yun@arm.com>
The ExtractGuidedSectionLib implementation in Embedded package
creates HOBs to get Uncompress handler information.
Since StandaloneMM is a HOB consumer and not a HOB producer,
a StandaloneMM instance of ExtractGuidedSectionLib has been
introduced.
Therefore, switch to using the StandaloneMM instance of the
ExtractGuidedSectionLib.
Also, when using Lzma compression for StandaloneMm the size
of the image can be reduced.
The image size reduction can be seen as below:
before:
FVMAIN_COMPACT [96%Full] 1048576 (0x100000) total,
1016224 (0xf81a0) used, 32352 (0x7e60) free
after:
FVMAIN_COMPACT [38%Full] 1048576 (0x100000) total,
402880 (0x625c0) used, 645696 (0x9da40) free
Signed-off-by: Levi Yun <yeoreum.yun@arm.com>
Instead of using Svc directly to request storage operation, use ArmFfaLib. Also, memory endpoint is no more used. so remove it. Signed-off-by: Levi Yun <yeoreum.yun@arm.com>
commit 8bc44608b8ea ("MdeModulePkg: Add ImagePropertiesRecordLib")
makes build failure on StandaloneMm.
commit f8d9a0a ("Update to New StackCheckLib")
replace BaseStackCheckLib to StackCheckLibNull.
To fix build failure,
1. add ImagePropertiesRecordLib and related libraries,
2. replace StackCheckLib to StackCheckLibNull.
Signed-off-by: Levi.Yun <yeoreum.yun@arm.com>
Add related libraries and Pcds to build StandaloneMm with FF-A v1.2. Signed-off-by: Levi Yun <yeoreum.yun@arm.com>
LeviYeoReum
force-pushed
the
ffa_milestone2
branch
from
e02bcad to
d313c51
Compare
StandaloneMmCoreEntryPoint Library and StandaloneMmCpu Driver for Arm are moved from StandaloneMmPkg to ArmPkg. apply this change. Signed-off-by: Levi.yun <yeoreum.yun@arm.com>
LeviYeoReum
force-pushed
the
ffa_milestone2
branch
from
d313c51 to
bc4c9eb
Compare
StandaloneMmCoreEntryPoint Library and StandaloneMmCpu Driver for Arm are moved from StandaloneMmPkg to ArmPkg. apply this change. Signed-off-by: Levi Yun <yeoreum.yun@arm.com>
LeviYeoReum
force-pushed
the
ffa_milestone2
branch
from
bc4c9eb to
1b50b57
Compare
samimujawar
reviewed
Dec 31, 2024
| @@ -81,6 +81,7 @@ | |||
| ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf | |||
| StandaloneMmMmuLib|ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf | |||
| ArmSvcLib|ArmPkg/Library/ArmSvcLib/ArmSvcLib.inf | |||
| ArmTransferListLib|ArmPkg/Library/ArmTransferListLib/ArmTransferListLib.inf | |||
There was a problem hiding this comment.
Please fix typo in commit message.
ArmTrnaferLib => ArmTransferLib
Also the subject line for this and other patches in this series needs to be updated.
e.g. for this patch the subject line should be
"Platform/Arm: VExpress: Add ArmTransferLib for StandaloneMm"
Similarly the subject line for patch 4 "Driver/Optee: apply ffa library" should be something like
"Drivers/OpTee/OpteeRpmbPkg: apply FF-A library"
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset fixes build failure StandaloneMm on VExporessPkg
and apply remove hob creation in StandaloneMm.
When StandaloneMm running with SPM_MM,
It passes Boot Hob list created in TF-A via transfer list according to firmware handoff spec[0].
When StandaloneMm running with FF-A,
It passes Boot Hob list created in TF-A via FF-A boot protocol[1].
For this, add related Libraries in StandaloneMm dsc file.
Links: https://github.com/FirmwareHandoff/firmware_handoff [0]
Links: https://developer.arm.com/documentation/den0077/latest/ [1]