CryptoPkg: Fix TlsSetCaCertificate

The before TlsSetCaCertificate use local variable is wrong. Signed-off-by: Wenxing Hou <wenxing.hou@intel.com>
tianocore · Jan 5, 2024 · dc429a5 · dc429a5
1 parent 3b16f97
commit dc429a5
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/CryptoPkg/Library/TlsLibMbedtls/TlsConfig.c b/CryptoPkg/Library/TlsLibMbedtls/TlsConfig.c
@@ -623,7 +623,7 @@ TlsSetCaCertificate (
   )
 {
   TLS_CONNECTION  *TlsConn;
-  mbedtls_x509_crt Crt;
+  mbedtls_x509_crt *Crt;
   INT32 Ret;
 
   TlsConn = (TLS_CONNECTION *)Tls;
@@ -636,13 +636,14 @@ TlsSetCaCertificate (
     return EFI_INVALID_PARAMETER;
   }
 
-  mbedtls_x509_crt_init(&Crt);
+  Crt = malloc(sizeof(mbedtls_x509_crt));
+  mbedtls_x509_crt_init(Crt);
 
-  Ret = mbedtls_x509_crt_parse_der(&Crt, Data, DataSize);
+  Ret = mbedtls_x509_crt_parse_der(Crt, Data, DataSize);
 
   if (Ret == 0) {
-    mbedtls_ssl_conf_ca_chain((mbedtls_ssl_config *)TlsConn->Ssl->conf, &Crt, NULL);
-    mbedtls_x509_crt_free(&Crt);
+    mbedtls_ssl_conf_ca_chain((mbedtls_ssl_config *)TlsConn->Ssl->conf, Crt, NULL);
+    mbedtls_ssl_conf_cert_profile((mbedtls_ssl_config *)TlsConn->Ssl->conf, &mbedtls_x509_crt_profile_default);
   }
 
   return (Ret == 0) ? EFI_SUCCESS : EFI_ABORTED;