SecurityPkg: Split get cert and digest from DoDeviceAuthentication #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zhiqiang520
reviewed
Oct 10, 2023
|
|
||
| if (((CapabilityFlags & SPDM_GET_CAPABILITIES_RESPONSE_FLAGS_CERT_CAP) == 0) || | ||
| ((CapabilityFlags & SPDM_GET_CAPABILITIES_RESPONSE_FLAGS_MEAS_CAP_SIG) == 0)) |
There was a problem hiding this comment.
why deleted this check (CapabilityFlags & SPDM_GET_CAPABILITIES_RESPONSE_FLAGS_MEAS_CAP_SIG) == 0) ?
Following the PFP spec, if the device does not support MEAS_CAP with signature, AuthState should also being AUTH_FAIL_NO_SIG.
There was a problem hiding this comment.
Thanks. I have moved the check to the DoDeviceMeasurement.
Add new feature: DoDeviceCertificate before DoDeviceAuthentication or DoDeviceMeasurement. Signed-off-by: Wenxing Hou <wenxing.hou@intel.com>
Wenxing-hou
force-pushed
the
split_get_cert_and_digest
branch
from
70e8d05
to
c41eea6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new feature: DoDeviceCertificate before DoDeviceAuthentication or DoDeviceMeasurement.