Skip to content

Commit

Permalink
BaseTools:Fix build tools print traceback info issue
Browse files Browse the repository at this point in the history
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2610

We meet a case that the DEC file declaring the PCD isn't
included in the INF.it cause build tools report Traceback error.

Remove raise statements that generate Tracebacks that were only
intended for development/debug. With the raise statements removed
proper error messages are shown.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
  • Loading branch information
zhijufan authored and mergify[bot] committed Mar 24, 2020
1 parent 0dee1d1 commit 2f524a7
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions BaseTools/Source/Python/AutoGen/AutoGenWorker.py
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,6 @@ def run(self):
CacheResult = Ma.CanSkipbyPreMakeCache()
except:
CacheResult = False
traceback.print_exc(file=sys.stdout)
self.feedback_q.put(taskname)

if CacheResult:
Expand All @@ -273,7 +272,6 @@ def run(self):
CacheResult = Ma.CanSkipbyMakeCache()
except:
CacheResult = False
traceback.print_exc(file=sys.stdout)
self.feedback_q.put(taskname)

if CacheResult:
Expand All @@ -285,7 +283,6 @@ def run(self):
except Empty:
pass
except:
traceback.print_exc(file=sys.stdout)
self.feedback_q.put(taskname)
finally:
self.feedback_q.put("Done")
Expand Down

0 comments on commit 2f524a7

Please sign in to comment.