-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BaseTools: Add VS2022 support. #5799
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@bcran can you please take a look at this when you get a chance? |
ghost
self-requested a review
June 20, 2024 01:44
ghost
changed the title
BuildTools: Add VS2022 support.
BaseTools: Add VS2022 support.
Jun 20, 2024
ghost
reviewed
Jun 20, 2024
ghost
requested a review
from lgao4
June 20, 2024 02:01
apop5
force-pushed
the
personal/apop5/vs2022
branch
from
June 20, 2024 04:38
f32fbeb
to
268430c
Compare
lgao4
reviewed
Jun 24, 2024
apop5
force-pushed
the
personal/apop5/vs2022
branch
from
June 24, 2024 15:28
268430c
to
7e8e63b
Compare
Adding tools_def for VS2022. Update WindowsVsToolChain to support VS2022. Update set_vsPrefix_envs and toolsetup and edksetup to support VS2022. Signed-off-by: Aaron Pop <aaronpop@microsoft.com>
apop5
force-pushed
the
personal/apop5/vs2022
branch
from
June 26, 2024 02:16
7e8e63b
to
36c019a
Compare
@bcran @lgao4 Do you have any other concerns? |
ghost
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding support for VS2022 build tools.
Adding tools_def for VS2022.
Update WindowsVsToolChain to support VS2022.
Update set_vsPrefix_envs and toolsetup and edksetup to support VS2022.
How This Was Tested
Ran build on local system (tool_chain_target=vs2022)
Ran CI on local system (tool_chain_target=vs2022).
Both tests found vs2022.
Integration Instructions
N/A