Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseTools: Add VS2022 support. #5799

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Conversation

apop5
Copy link
Contributor

@apop5 apop5 commented Jun 20, 2024

Description

Adding support for VS2022 build tools.

Adding tools_def for VS2022.
Update WindowsVsToolChain to support VS2022.
Update set_vsPrefix_envs and toolsetup and edksetup to support VS2022.

  • Breaking change?
    • Breaking change - Will this cause a break in build or boot behavior?
    • Examples: Add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does the change have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Ran build on local system (tool_chain_target=vs2022)
Ran CI on local system (tool_chain_target=vs2022).
Both tests found vs2022.

Integration Instructions

N/A

@apop5 apop5 marked this pull request as ready for review June 20, 2024 01:16
@apop5
Copy link
Contributor Author

apop5 commented Jun 20, 2024

@bcran

can you please take a look at this when you get a chance?

@ghost ghost self-requested a review June 20, 2024 01:44
@ghost ghost changed the title BuildTools: Add VS2022 support. BaseTools: Add VS2022 support. Jun 20, 2024
BaseTools/Conf/tools_def.template Outdated Show resolved Hide resolved
BaseTools/Conf/tools_def.template Outdated Show resolved Hide resolved
BaseTools/Conf/tools_def.template Outdated Show resolved Hide resolved
BaseTools/set_vsprefix_envs.bat Outdated Show resolved Hide resolved
@ghost ghost requested a review from lgao4 June 20, 2024 02:01
Adding tools_def for VS2022.
Update WindowsVsToolChain to support VS2022.
Update set_vsPrefix_envs and toolsetup and edksetup to support VS2022.

Signed-off-by: Aaron Pop <aaronpop@microsoft.com>
@apop5
Copy link
Contributor Author

apop5 commented Jul 3, 2024

@bcran @lgao4

Do you have any other concerns?

@os-d os-d mentioned this pull request Jul 5, 2024
3 tasks
@ghost ghost added the push Auto push patch series in PR if all checks pass label Jul 8, 2024
@mergify mergify bot merged commit 95a6892 into tianocore:master Jul 8, 2024
127 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants