Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standard Libraries: vsnprintf_ss: fix assert check on uninitialized vari... #7

Closed
wants to merge 2 commits into from
Closed

Standard Libraries: vsnprintf_ss: fix assert check on uninitialized vari... #7

wants to merge 2 commits into from

Commits on Mar 24, 2015

  1. Standard Libraries: vsnprintf_ss: fix assert check on uninitialized v… 

    …ariable.

Variable n is not yet initialized when the _DIAGASSERT() check is performed
on it, which means any old garbage in n may or may not cause the assert
to occur.  I believe this is a cut-n-paste error from vsnprintf() where
n is used as a paramater, where as vsnprintf_ss() does not.

Fix this by not asserting on n.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Colin Ian King committed Mar 24, 2015
    Configuration menu
    Copy the full SHA
    dcfb470 View commit details
    Browse the repository at this point in the history

  2. StdLib: Fix memory leak in error return path of res_mkupdrec 

    rrecp has been allocated but is not freed on the error return
path if the strdup fails.  This is a minor memory leak that is
easily fixed by free'ing rrecp on the error return.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Colin Ian King committed Mar 24, 2015
    Configuration menu
    Copy the full SHA
    a1dd2f4 View commit details
    Browse the repository at this point in the history