Select number of phases setting #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll have to double check, but I'm fairly certain it is not guaranteed that L1 will be the reporting phase on a 1-phase grid. |
|
I see. Then lets check to see what phases have no value, and hide them. Then show all three when setting is switched back. Will work on rare 2-phase installations as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
On a 1-phase power-grid we do not need the two empty phases measuring no current, so I wanted a setting to hide them from capabilities view.
What
I added a checkbox setting to the Pulse and Watty drivers
Default value is true (most people have 3-phases)
Upon change it removes/adds the capabilities measure_current.L2 and measure_current.L3 on the device
Test
Tested on Pulse. ✔️
Watty not tested, but should work similarly.