Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag bug when the mouse moves outside gridster in an iframe (Chrome) #405

Closed
dchipan opened this issue Aug 8, 2018 · 14 comments
Closed

Comments

@dchipan
Copy link

dchipan commented Aug 8, 2018

Hi,

I have a gridster grid in an iframe. When I drag an item and my mouse moves outside the iframe, I can not drop the item any more even if I move back to the iframe.

The only solution from this point is to reload the entire page.

It works well on Firefox 61.0 but not in Chrome 68.0.

Any idea, help ?

See JsFiddle to reproduce it : https://jsfiddle.net/vfL03a4c/

@dchipan
Copy link
Author

dchipan commented Aug 8, 2018

This JsFiddle seems to work well (Grister without Angular) : https://jsfiddle.net/49bwtdgy/embedded/result/

@CollinGraf314
Copy link
Collaborator

I've checked this out and can confirm the bug. If anyone is willing to make a pull request with a fix I'll review it and check it in.

dchipan added a commit to dchipan/angular-gridster2 that referenced this issue Aug 17, 2018
Drag bug when the mouse moves outside gridster in an iframe (Chrome) tiberiuzuld#405
CollinGraf314 added a commit that referenced this issue Aug 21, 2018
Drag bug when the mouse moves outside gridster in an iframe (Chrome) #405
@nakulkundra
Copy link

will this be fixed in the 4.x as well ?

@CollinGraf314
Copy link
Collaborator

CollinGraf314 commented Aug 22, 2018

I will not fix it in 4.x. Since this repository is Tiberiuzuld's and I am only trying to maintain it in his absence, I will not be patching any past releases.

However, you can always add the fix yourself by looking at dchipan's changes and modifying your local version of the library.

@nakulkundra
Copy link

nakulkundra commented Aug 22, 2018 via email

@dchipan
Copy link
Author

dchipan commented Aug 23, 2018

First of all thanks for the merge. Now, how can I use fixed code ? Is it possible to release a new version (5.3.4 ?) before September ?

@CollinGraf314
Copy link
Collaborator

v5.3.4 was just released with this bug fix.

@nakulkundra
Copy link

nakulkundra commented Aug 23, 2018 via email

@CollinGraf314
Copy link
Collaborator

I mean you can upgrade your project to angular 5 really easily if you follow angular's migration guide, as there are very few breaking changes between the two. Otherwise, you can fork the 4.x branch of this repository, fix the bug (probably using dchipan's pull request as reference) and then make a pull request.

@ghost
Copy link

ghost commented Aug 24, 2018

@CollinGraf314 I am using angular-gridster latest version 6.0.5 npm package with angular 6, How do I get this fix without reverting to a previous version?

@CollinGraf314
Copy link
Collaborator

You can't right now. But I'll be adding the bug fix to 6.x and making a new release today. Just look out for that new release.

@CollinGraf314
Copy link
Collaborator

Just made a new release for v6.0.6 which includes the fix.

@nakulkundra
Copy link

@dchipan can you please help me by reviewing

#436

have changed it based on your changes.

@roshansinghcuembux
Copy link

roshansinghcuembux commented Jul 19, 2023

This issue is still not resolved entirely.
I have faced an issue multiple times while resizing widgets on the Gridster.
According to my observation, the issue occurs when we try to resize a widget and take the cursor outside the container or iframe. I have found that the issue is similar to what is fixed in the #409 (@CollinGraf314 @dchipan ).
However, it needs to be handled for resizing functionality as well.

File Name: gridsterResizable.service.ts
Error: Cannot read properties of undefined (reading 'pushItems')
Cannot read properties of undefined (reading 'setPushedItems')
I have attached images for reference.

It would be really great if someone can fix this for tag version 7.2.0.

console error

Code Snapshot

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants