Ziad/immersive audio param support #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgrevehagen
previously approved these changes
May 31, 2024
ziad-halabi9
force-pushed
the
ziad/immersive-audio-param-support
branch
from
f3d422d to
6796e71
Compare
Added AudioModeRepository to contain the immersive audio setting which will be used when making playbackinfo requests.
ziad-halabi9
force-pushed
the
ziad/immersive-audio-param-support
branch
from
6796e71 to
ca7763e
Compare
kgrevehagen
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
playbackinfoendpoint now supports a new boolean parameter calledimmersiveaudio. When set to false, backend will return a stereo version of the requested track if it's an immersive audio track.In this PR, we add support for the new parameter as well as having this setting under the playback controls in the test app to easily test this.