Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better envelopes #522

Closed
Tracked by #671
felixroos opened this issue Mar 17, 2023 · 2 comments
Closed
Tracked by #671

better envelopes #522

felixroos opened this issue Mar 17, 2023 · 2 comments
Labels
enhancement improves an existing feature

Comments

@felixroos
Copy link
Collaborator

envelopes will have pops when the hap is shorter than attack + decay. cancelAndHoldAtTime supposedly fixes this (in chrome only, see https://bugzilla.mozilla.org/show_bug.cgi?id=1308431 which is blocked by WebAudio/web-audio-api#2437). it seems there is actually no real solution right now??
some clues could be found in one of:

@felixroos felixroos added the bug Something isn't working label Mar 17, 2023
@felixroos felixroos added enhancement improves an existing feature and removed bug Something isn't working labels Mar 23, 2023
@felixroos
Copy link
Collaborator Author

another design that could be chosen is to just add a t = Math.max(t, begin + attack + decay) inside stop returned by getEnvelope to make sure the sound duration is at least completing the attack and decay phase (reaching sustain level) before starting the release. This should prevent all pops + might even be musically useful

@felixroos
Copy link
Collaborator Author

fixed with #861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improves an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant