fix: finally repair envelopes #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finally found a reasonable fix for #522 !
Up until now, the release phase was triggered when the event was over. This led to crackles when the sustain level was not yet reached, or in other words:
attack+decay > hap.duration ? crackle() : nocrackle()to fix sudden jumps in the envelope, the release now waits for the decay phase to finish, to make sure the automation starts from a value that is actually reached (not creating a sudden jump / crackle).
This is even musically useful, because the envelope can now be used to make the sound longer, even if it exceeds the event duration.
Technically, this is a breaking change, but it will only "break" patterns with crackles, so I guess this is not too bad