Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consume n with scale #727

Merged
merged 2 commits into from
Oct 7, 2023
Merged

consume n with scale #727

merged 2 commits into from
Oct 7, 2023

Conversation

felixroos
Copy link
Collaborator

this was causing weird behavior when using n with scale + a sample or a synth:

n("0 1 2").scale("C:major").log() // logs note: c3, n: 0 etc...
.s("bd") // <-- n is now also used here

now, n is gone after scale, so it won't also change the sample, which is unexpected. the same also happens with synths, where the n would change the timbre unexpectedly

@felixroos felixroos merged commit daf965f into main Oct 7, 2023
2 checks passed
@felixroos felixroos deleted the fix-n-scale branch October 7, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant