feat(release): Move release to GitHub Actions. #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betterengineering
force-pushed
the
mark/migrate-release-to-github
branch
2 times, most recently
from
85af2e6
to
d0ccd15
Compare
This commit moves our release process to GitHub actions. The way this used to work was through our internal build system which makes it really hard to give any visibility to anyone else. In addition, we were hitting the limits of our local macOS build system and needed an upgraded agent.
betterengineering
force-pushed
the
mark/migrate-release-to-github
branch
from
d0ccd15
to
a458eea
Compare
rohansingh
reviewed
Jan 3, 2022
3 tasks
This commit splits workflows so that pull requests and main have differnt workflows.
rohansingh
reviewed
Jan 3, 2022
Co-authored-by: Rohan Singh <rohan@tidbyt.com>
|
👏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Our build system is pretty complicated today and spans across two different CI/CD solutions with one being private and one being public. This change moves everything into GitHub actions and makes use of all of the ARM64 changes in #81 and #93. With this change, we will now:
v.v0.8.3for example.Changes
Tests
I did as much testing as I can through tweaking the build configuration and observing behavior with the branch/tagging conditionals commented out. It's pretty close, but I imagine when we make our first git tag it will run into some issue that was missed.