Add zipfile module #826
Merged
Add zipfile module #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pixlet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- Also required for the MARTA sample app using GTFS protocol buffers as their - Basically just importing a starlib module, but wrapping slightly to make usage more consistent with other pixlet - The style that starlib used here is familiar from working with starlark at Google, but my guess is it's not familiar to most users, and it also isn't consistent with other starlib modules ¯\_(ツ)_/¯
bralax
approved these changes
Jul 28, 2023
betterengineering
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Thanks for the change @dinosaursrarr! This is fine for now, though I suspect the real issue will be folks wanting to download large zip files. We have some constraints around HTML body size in our backend though, so it shouldn't be an issue 🤞
|
Yeah, GTFS-realtime is the use case that keeps coming up. And it's just an infeasible amount of data to process, which is why I hadn't sent this in before. But at least this way developers can find that out for themselves (and locally), rather than feeling artificially limited by pixlet. |
dinosaursrarr
added a commit
to dinosaursrarr/tidbyt.dev
that referenced
this pull request
Apr 27, 2024
Realised I had a few PRs on that updated docs on the main repo, but not here where more people will see them: - tidbyt/pixlet#826 - tidbyt/pixlet#827 - tidbyt/pixlet#853
rohansingh
pushed a commit
to tidbyt/tidbyt.dev
that referenced
this pull request
May 15, 2024
Realised I had a few PRs on that updated docs on the main repo, but not here where more people will see them: - tidbyt/pixlet#826 - tidbyt/pixlet#827 - tidbyt/pixlet#853
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw this requested in [Feature] Support for zip file processing #812. I did this ages ago for a project I never finished but realised it could be an easy win.
Basically just importing a starlib module, but wrapping slightly to make usage more consistent with other pixlet modules
The style that starlib used here is familiar from working with starlark at Google, but my guess is it's not familiar to most users, and it also isn't consistent with other starlib modules ¯_(ツ)_/¯