Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow using widget as primary control in XML View #949

Merged
merged 6 commits into from
Apr 27, 2020

Conversation

brentonhouse
Copy link
Contributor

No description provided.

@brentonhouse brentonhouse self-assigned this Dec 18, 2019
@build
Copy link

build commented Dec 18, 2019

Warnings
⚠️

Please ensure to add a changelog entry for your changes. Edit the CHANGELOG.md file and add your change under the Unreleased items header

Messages
📖

✅ All tests are passing
Nice one! All 3490 tests are passing.

Generated by 🚫 dangerJS against 5d4889e

@brentonhouse brentonhouse changed the title Add ability to use widget as primary control in XML View [ALOY-1256] - Add ability to use widget as primary control in XML View Dec 18, 2019
Copy link
Contributor

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to have broken the use case here.

Maybe we only want to do code += '.getViewEx({recurse:true});\n'; when type === 'widget', and maintain the existing behaviour for all other use cases?

@brentonhouse
Copy link
Contributor Author

This looks to have broken the use case here.

Maybe we only want to do code += '.getViewEx({recurse:true});\n'; when type === 'widget', and maintain the existing behaviour for all other use cases?

This seems to be a greater issue of a require/widget code generator not being aware that it is generating code inside of a Ti.UI.Tab element. Let me take a look and see if I can pass in some additional information from inside the compile/parsers/Ti.UI.Tab.js file. That way the require/widget can have enough context to generate properly.

@brentonhouse
Copy link
Contributor Author

@ewanharris - I've added support for when widgets/require are in Tabs now

Copy link
Contributor

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me. I'm going to hold off merging until we're post 8.0.0 just incase we have to rev Alloy for any found issues

@ewanharris ewanharris changed the title [ALOY-1256] - Add ability to use widget as primary control in XML View fix: allow using widget as primary control in XML View Apr 27, 2020
@ewanharris ewanharris merged commit 9e10163 into tidev:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants