-
-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow using widget as primary control in XML View #949
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks to have broken the use case here.
Maybe we only want to do code += '.getViewEx({recurse:true});\n';
when type === 'widget'
, and maintain the existing behaviour for all other use cases?
This seems to be a greater issue of a require/widget code generator not being aware that it is generating code inside of a Ti.UI.Tab element. Let me take a look and see if I can pass in some additional information from inside the |
@ewanharris - I've added support for when widgets/require are in Tabs now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good to me. I'm going to hold off merging until we're post 8.0.0 just incase we have to rev Alloy for any found issues
No description provided.