Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android)(8_1_X): splash open animation sometimes stutters on cold start #11140

Merged
merged 2 commits into from
Aug 20, 2019

Conversation

jquick-axway
Copy link
Contributor

- [TIMOB-27328] Fixed bug where opening a window while splash is in mid-transition causes splash to adopt child window's transition. Causes noticeable stutter.
  * Especially an issue as of Android Q beta 4.
  * Modified so that activity windows launched from splash override pending transition with fade-in transition instead. (Looks better than slide-up animation anyways.)
@jquick-axway jquick-axway added this to the 8.1.1 milestone Aug 12, 2019
@build build requested a review from a team August 13, 2019 00:31
@build
Copy link
Contributor

build commented Aug 13, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 3728 tests are passing.
(There are 470 tests skipped)

Generated by 🚫 dangerJS against 3fe9831

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@ssjsamir ssjsamir self-requested a review August 19, 2019 14:36
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: No longer able to see the stutter on the splash screen using the test steps above.

Test environment

MacOS Mojave version 10.14.4
Node.js: 8.11.3
Pixl 3 Sim (Android Q)
"NPM":"4.2.14","CLI":"7.1.1-master.2"
Java Version: 1.8.0_131
NDK: 12.1.2977051

@sgtcoolguy sgtcoolguy merged commit 74f6e10 into tidev:8_1_X Aug 20, 2019
rlustemberg added a commit to inzdr/titanium_mobile that referenced this pull request Aug 21, 2019
* 8_1_X: (46 commits)
  fix(ios): exclude all frameworks from optimizing files step (8_1_X) (tidev#10996)
  fix(android): fix asset encryption on windows 32bit java (tidev#11155)
  fix(ios): add script message handler for local files only (tidev#11086)
  fix(android): improve merge of <uses-feature/> elements (tidev#11111)
  fix(android): splash open animation sometimes stutters on cold start (tidev#11140)
  fix(android): fix dialog without selectedIndex reusage
  fix(android): resuming with intent "FLAG_ACTIVITY_MULTIPLE_TASK" can hang the app (tidev#11081)
  fix(android): regression where closing root window from child window causes app exit issues as of 8.0.1 (tidev#11093)
  fix(android): fix reusing a dialog with a new "parent" window (tidev#11096)
  chore(release): bump version
  fix(ios): console.log does not log properly if it has multiple arguments (tidev#11125)
  fix(android): update titanium_prep windows binaries
  chore(android)(8_1_X): update titanium_prep binaries (tidev#11100)
  fix(android)(8_1_X): ListView's SearchBar/SearchView wrongly overlaps rows as of 8.0.1 (tidev#11105)
  chore(android): update aps-analytics (tidev#11101)
  fix(ios): fix crashes in calendar upon giving permission (tidev#11078)
  fix(ios,android)(8_1_X): implement exception signal handler (tidev#11077)
  fix(cli): add deprecation notice for node < 10.13 (tidev#11063)
  test(db): bump up timeout
  test(db): drop long-running query count to 5000 rows
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants