Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): fix losing elevation effect after dimensions change #11280

Merged
merged 3 commits into from
Dec 16, 2019

Conversation

ypbnv
Copy link
Contributor

@ypbnv ypbnv commented Oct 15, 2019

JIRA: https://jira.appcelerator.org/browse/TIMOB-25945

Description:
Fixes the loss of the elevation property effect after a view's dimensions have been changed
dynamically.
No unit test, since this is a visual bug.
Thanks to @garymathews for dealing with it!

Test case:
app.js

var win = Ti.UI.createWindow({ backgroundColor: 'white' }),
	view1 = Ti.UI.createView({ backgroundColor: 'white',
							elevation: 50,
							width: 200,
							height: 100,
							top: 50,
							borderWidth: 5 });
view1.addEventListener('click', function() {
	view1.height += 50;
});
win.add(view1);
win.open();

Fixes the loss of the elevation property effect after a view's dimensions have been changed
dynamically
@ypbnv ypbnv added this to the 8.3.0 milestone Oct 15, 2019
@ypbnv ypbnv requested a review from garymathews October 15, 2019 14:07
@build build requested a review from a team October 15, 2019 14:21
@build
Copy link
Contributor

build commented Oct 15, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6680 tests are passing.
(There are 700 skipped tests not included in that total)

Generated by 🚫 dangerJS against 0d5e74c

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@sgtcoolguy sgtcoolguy removed this from the 8.3.0 milestone Dec 10, 2019
@ssjsamir ssjsamir self-requested a review December 12, 2019 14:01
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Tested using the test case in the description above and tested using the test case in https://jira.appcelerator.org/browse/TIMOB-25945

Test Environment

MacOS Catalina 10.15.1 beta
Xcode 11.3
Node.js 10.16.3
"NPM":"4.2.15-1","CLI":"7.1.2-7"
Pixel xl (Android 10)

@build build added this to the 9.0.0 milestone Dec 16, 2019
@sgtcoolguy sgtcoolguy merged commit f46784b into tidev:master Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants