Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: optimize png's for decreased file size #11321

Merged
merged 5 commits into from
Dec 2, 2019
Merged

chore: optimize png's for decreased file size #11321

merged 5 commits into from
Dec 2, 2019

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Nov 9, 2019 •
edited
Loading

JIRA: https://jira.appcelerator.org/browse/AC-6444

Optional Description:

optipng -o7 on all png's. Saving a few MB

@m1ga m1ga changed the title Optimize pngs Optimize png files Nov 9, 2019
@build build added this to the 9.0.0 milestone Nov 9, 2019
@build build requested a review from a team November 9, 2019 23:54
@build
Copy link
Contributor

build commented Nov 9, 2019 •
edited
Loading

Warnings
⚠️

Commit 69bcb26650bde46086a399bc639b6c0d9715badd has a message "optimize all pngs" giving 2 errors:

  • subject may not be empty
  • type may not be empty
Messages
📖

💾 Here's the generated SDK zipfile.
📖 🎉 Another contribution from our awesome community member, m1ga! Thanks again for helping us make Titanium SDK better. 👍
📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.
📖

✅ All tests are passing
Nice one! All 6623 tests are passing.
(There are 711 skipped tests not included in that total)

Generated by 🚫 dangerJS against 74331f9

@sgtcoolguy sgtcoolguy requested review from a team November 11, 2019 19:06
janvennemann
janvennemann approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Compared a couple files from this PR with master and couldn't see any noticeable difference except for the decreases file size.

@janvennemann janvennemann changed the title Optimize png files chore: optimize png's for decreases file size Nov 26, 2019
@janvennemann janvennemann changed the title chore: optimize png's for decreases file size chore: optimize png's for decreased file size Nov 26, 2019
@ssjsamir ssjsamir self-requested a review November 28, 2019 10:46
ssjsamir
ssjsamir approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed, able to see a slight decrease in file sizes.

Test Environment

MacOS Catalina 10.15.1 beta
Xcode 11
Node.js 10.16.3
iphone 8 13.2
"NPM":"4.2.15-1","CLI":"7.1.2-7"

@lokeshchdhry lokeshchdhry merged commit e563e28 into tidev:master Dec 2, 2019
@m1ga m1ga deleted the png branch January 28, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvennemann janvennemann janvennemann approved these changes

@ssjsamir ssjsamir ssjsamir approved these changes

Assignees
No one assigned
Labels
community 🔥 docs in-qe-testing 🕵
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@m1ga @build @janvennemann @ssjsamir @lokeshchdhry