Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): prevent snapshots from failing build #11367

Merged
merged 4 commits into from
Nov 26, 2019
Merged

fix(android): prevent snapshots from failing build #11367

merged 4 commits into from
Nov 26, 2019

Conversation

garymathews
Copy link
Contributor

  • Implement fallback for when a snapshot fails to generate for a platform.

JIRA Ticket

@build build added this to the 9.0.0 milestone Nov 25, 2019
@build build requested a review from a team November 25, 2019 22:19
@build
Copy link
Contributor

build commented Nov 25, 2019 •
edited
Loading

Warnings
⚠️

android/cli/commands/_build.js#L3288 - android/cli/commands/_build.js line 3288 – 'url.parse' was deprecated since v11.0.0. Use 'url.URL' constructor instead. (node/no-deprecated-api)
⚠️

build/lib/android/index.js#L7 - build/lib/android/index.js line 7 – 'git' is assigned a value but never used. (no-unused-vars)
Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6623 tests are passing.
(There are 711 skipped tests not included in that total)

Generated by 🚫 dangerJS against f6ad364

@garymathews garymathews merged commit 40bd1d9 into tidev:master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquick-axway jquick-axway jquick-axway requested changes

Assignees
No one assigned
Labels
android bug no tests
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@garymathews @build @jquick-axway