-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: convertPointToView() to use "ti.ui.defaultunit" #12320
Conversation
Fixes TIMOB-27807
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR brings current behaviour inline with iOS. However, I brought up that Point can accept String
parameters allowing units to be specified. @jquick-axway found that iOS also did not support this. So either we drop String
support, or allow units to be specified.
Updated PR. Now supports x/y string value with units postfixed to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Passed: Tested using the test case mentioned above. Note* As mentioned in the description the Android test case wobbles but this is a separate issue.
Test Environment
MacOS Big Sur: 11.1 Beta 1
Xcode: 12.2 Beta
Java Version: 1.8.0_242
Android NDK: 21.3.6528147
Node.js: 12.18.1
""NPM":"5.0.0","CLI":"8.1.1""
Pixel XL (10.0) Sim
JIRA:
https://jira.appcelerator.org/browse/TIMOB-27807
Summary:
convertPointToView()
always returns pixels on Android.convertPointToView()
always returns dips on iOS.convertPointToView()
to accept x/y point string values with post-fixed units.Test:
<property name="ti.ui.defaultunit" type="string">px</property>
app.js