fix(ios): fix crash on soft-restart #13693
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crash happens when soft-restarting the app (e.g. with https://github.com/rborn/tiapprestart) after opening an Universal Link / User Activities API. The reason is that we override the internal
NSUserActivity
to aNSDictionary
during initial launch any try to re-access the native value that is already mapped to a dictionary at this point.The testing setup is a bit complex, but it's basically this:
-> App crashes!