Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): fix crash on soft-restart #13693

Merged

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn commented Dec 29, 2022

This crash happens when soft-restarting the app (e.g. with https://github.com/rborn/tiapprestart) after opening an Universal Link / User Activities API. The reason is that we override the internal NSUserActivity to a NSDictionary during initial launch any try to re-access the native value that is already mapped to a dictionary at this point.

The testing setup is a bit complex, but it's basically this:

  1. Download the ti.apprestart module: https://github.com/rborn/tiapprestart
  2. Setup Universal Links: https://stackoverflow.com/questions/36542001/appcelerator-how-to-add-universal-links-support-in-ios9-app
  3. Open a universally-linked URL
  4. Return to the app
  5. Trigger an app restart

-> App crashes!

@hansemannn hansemannn merged commit 1128407 into tidev:master Jan 5, 2023
hansemannn added a commit that referenced this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant