Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(android): prepare SDK for Android 34 #13940

Merged
merged 6 commits into from
Jun 25, 2024
Merged

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Oct 27, 2023

Update

According to the email from today (06/18) :

As a reminder, from August 31, Google Play requires all new app releases to target Android 14.

it will be required for new apps in August.

The Google pages don't show that yet:
https://developer.android.com/google/play/requirements/target-sdk and https://support.google.com/googleplay/android-developer/answer/11926878?sjid=9819215519281928158-EU



PR Changes

There is only one change if you use a broadcast receiver in your app and you might see one of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when receiver isn't being registered exclusively for system broadcasts



After this PR users can set <uses-sdk android:targetSdkVersion="34"/> in their tiapp.xml to target Android 34. It is not set by default inside the SDK.



Test

const win = Ti.UI.createWindow();
var broadcastReceiver = Ti.Android.createBroadcastReceiver({
	onReceived: function(e) {}
});
Ti.Android.registerBroadcastReceiver(broadcastReceiver, ['com.appcelerator.action.ALERT']);
win.open();

tiapp.xml:

 <android>
        <manifest>
          <uses-sdk android:targetSdkVersion="34"/>
          <uses-permission android:name="com.appcelerator.action.ALERT"/>
        </manifest>
    </android>

Results:

  • 12.3.1.GA will show One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts
  • this PR won't show the error

@m1ga m1ga mentioned this pull request Feb 13, 2024
1 task
This was referenced Mar 23, 2024
@m1ga m1ga marked this pull request as ready for review June 18, 2024 18:13
@m1ga
Copy link
Contributor Author

m1ga commented Jun 18, 2024

⚠️ Needs to be tested with different apps/users

Depending on the SDK release timing we can also do the following:

  • merge the code changes and keep the targetSDK to 33
  • users with new apps can change the targetSDK by hand in tiapp.xml
  • users with updates can keep 33 as long as needed
  • we have more time to test and get some field reports by users who want to go 34 already

Update:
I've changed the target SDK back to 33 and will do another PR for the 34 change

@m1ga m1ga changed the title chore(android): target API 34 chore(android): prepare SDK for Android 34 Jun 19, 2024
@hansemannn hansemannn merged commit ada10bb into master Jun 25, 2024
5 checks passed
@m1ga m1ga deleted the 231027_android14 branch June 25, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants