Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): fix debug issues with scenes #13979

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

hansemannn
Copy link
Collaborator

The debugger now works, so I am adding the initial changes + the debug changes here.

Copy link
Collaborator

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Debugging works in VS Code just fine (well just as fine as it ever has) 🚀

@hansemannn hansemannn merged commit 8bcd5c3 into tidev:master Jan 30, 2024
5 checks passed
@hansemannn hansemannn deleted the fix/ios-kroll-debug-master branch January 30, 2024 22:41
hansemannn added a commit that referenced this pull request Jan 31, 2024
* Revert "Revert "feat(ios): support multi-scene applications (#13941)""

This reverts commit 4a1d20f.

* fix: defer loading kroll-core to scene initialization
# Conflicts:
#	iphone/TitaniumKit/TitaniumKit/Sources/API/TiApp.m
hansemannn added a commit that referenced this pull request May 26, 2024
This reverts commit bfc87a6.

Revert "fix(ios): fix debug issues with scenes (#13979)"

This reverts commit 8bcd5c3.

Revert "fix(ios): fix various issues related to the scene migration (#13981)"

This reverts commit 6e40edb.

Revert "fix(ios): restore compatibility for Ti.App._resumeRestart() (#13989)"

This reverts commit 3a44b3d.

Revert "fix(ios): fix some open issues related to scenes (#14020)"

This reverts commit a0a3aea.

chore: restore start sequence
hansemannn added a commit that referenced this pull request May 26, 2024
This reverts commit bfc87a6.

Revert "fix(ios): fix debug issues with scenes (#13979)"

This reverts commit 8bcd5c3.

Revert "fix(ios): fix various issues related to the scene migration (#13981)"

This reverts commit 6e40edb.

Revert "fix(ios): restore compatibility for Ti.App._resumeRestart() (#13989)"

This reverts commit 3a44b3d.

Revert "fix(ios): fix some open issues related to scenes (#14020)"

This reverts commit a0a3aea.

chore: restore start sequence

# Conflicts:
#	iphone/TitaniumKit/TitaniumKit/Sources/API/TiApp.h
#	iphone/TitaniumKit/TitaniumKit/Sources/API/TiApp.m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants