Massively reduce flakiness

[MichaelChirico]

Closes #308.

Also switch to expect_setequal() for readability. Note that recent {testthat} makes expect_setequal() more attractive:

r-lib/testthat#1657

[hfrick]

Thank you but closing since it's outdated, see also #308 (comment)

[MichaelChirico]

Oh, @hfrick, actually this PR changed a different test:

dials/tests/testthat/test-aaa_values.R

Lines 174 to 178 in 55763e0

	expect_equal(
	sort(unique(value_sample(value_seq, 40))),
	value_seq$values
	)
	})

Should I change it to use the same "test for subset" approach?

[hfrick]

Oh, good catch! Yeah, would you make a fresh PR and change both of those expectations to that approach? If you want to go for using expect_in(), that would be a nice upgrade.

[github-actions]

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.