Implement the standardized proportion z statistic for one categorical variable #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echasnovski
approved these changes
Dec 21, 2020
ismayc
approved these changes
Dec 21, 2020
simonpcouch
added a commit
that referenced
this pull request
Dec 22, 2020
need the new z functionality from #351
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In working through #347, I realized that we had yet to implement a standardized proportion z statistic for one categorical variable.
It seems like there was previously an implementation that was no longer dispatched to, returning
xitself instead of the statistic. (I think we should raise a similar warning to the one that's currently commented out in those situations. Glad to put in a PR there if others are on board.) I just resituated the implementation, updating its references to the internals of thexobject and making surehypothesize()brings along the appropriate attributes.🐏