Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to "main" #426

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Move to "main" #426

merged 1 commit into from
Nov 1, 2021

Conversation

juliasilge
Copy link
Member

Closes #419

@juliasilge
Copy link
Member Author

Hello there, infer maintainers! I have moved the default branch to main after chatting with Mine and this PR contains some needed updates to use main as the default branch. However, it looks like I haven't set everything up completely correctly to handle your setup, especially the vdiffr tests. Could you all take a look and see what needs to happen here to complete the shift to main?

@simonpcouch
Copy link
Collaborator

Thanks so much for making this happen! Looking into the vdiffr failures—wondering if this is related to #424 and we somehow missed recent breaking changes in visualize dependencies. Hoping to make time to look into this this afternoon.

simonpcouch added a commit that referenced this pull request Nov 1, 2021
i don't have permissions to trigger workflows via the Actions panel, but want to see whether the check results here will trigger vdiffr failures a la #426
@simonpcouch
Copy link
Collaborator

Thanks for all of the Actions cleanup! Will follow your lead and modernize {broom}'s as well once these vdiffr failures are sorted out.

Super strange failures with vdiffr, and don't seem to be related to those in #424. Seems like some sort of graphical failure appearing in a band on the LHS for each of the many failures:

Screen.Recording.2021-10-31.at.8.29.33.PM.mov

Just triggered checks on #427 to see if I can replicate those test failures with the existing Actions setup. If so, I vote we go ahead and merge Julia's changes and open a separate issue for the vdiffr failures.

@mine-cetinkaya-rundel
Copy link
Collaborator

That sounds good to me @simonpcouch!

@simonpcouch
Copy link
Collaborator

Same vdiffr failures on #427 with the existing Actions setup. Will go ahead and merge here and open a separate issue for those. Thanks again, @juliasilge. :-)

@simonpcouch simonpcouch merged commit 2aa949c into main Nov 1, 2021
@simonpcouch simonpcouch deleted the main-changes branch November 1, 2021 14:13
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move master branch to main
3 participants