Type checkers part 2 #1391
Type checkers part 2 #1391
Conversation
| @@ -107,13 +107,7 @@ step_other <- | |||
| objects = NULL, | |||
| skip = FALSE, | |||
| id = rand_id("other")) { | |||
| if (!is_tune(threshold)) { | |||
There was a problem hiding this comment.
There's a lot of moving things here and in #1387. My rationale is that, if a the tuning process inserts a value, we would not check it. For example, finalize_recipe() does use the constructor.
It does defer the checking until prep-time which is later than this but it seems like the only way to really be sure that we are getting corrrect inputs.
| ) | ||
| expect_snapshot( | ||
| rec %>% step_window(y1, size = pi) | ||
| rec %>% step_window(y1, size = 3 + .Machine$double.eps) %>% prep() |
There was a problem hiding this comment.
So I don't know that we need both of the tests using .Machine$double.eps but it did affirm my belief of what should happen given how all_equal() works.
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue. |
Complement of #1387
This should do it for the new type checkers in this package.