conversion of warnings and errors to cli #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topepo
commented
Oct 23, 2024
| @@ -372,37 +364,37 @@ check_metrics <- function(x, object) { | |||
| is_surv_metric_set <- inherits(x, c("survival_metric_set")) | |||
|
|
|||
| if (!is_numeric_metric_set && !is_class_prob_metric_set && !is_surv_metric_set) { | |||
| rlang::abort("The `metrics` argument should be the results of [yardstick::metric_set()].") | |||
| cli::cli_abort("The {.arg metrics} argument should be the results of | |||
| {.fn yardstick::metric_set}.") | |||
There was a problem hiding this comment.
Previous messages has [pkg:fun()] format. Do we want to move to that? I don't think that they were clickable.
topepo
commented
Oct 23, 2024
| "The first argument needs to be an object with class 'tune_results'." | ||
| ) | ||
| cli::cli_abort("The first argument needs to be {.cls tune_results} object, | ||
| not {.obj_type_friendly {mtcars}}.") |
There was a problem hiding this comment.
I'm using obj_type_friendly a lot in these messages.
topepo
commented
Oct 23, 2024
| cli::cli_abort( | ||
| "There is no `fit_best()` method for an object with \\ | ||
| {cli::qty(cls)} class{?es} {.var {cls}}." | ||
| "No {.fn fit_best} exists for {.obj_type_friendly {x}}." |
There was a problem hiding this comment.
I standardized on this message for all of the main default methods.
topepo
commented
Oct 23, 2024
topepo
commented
Oct 23, 2024
| @@ -322,7 +320,8 @@ plot_param_vs_iter <- function(x, call = rlang::caller_env()) { | |||
| param_cols <- get_param_columns(x) | |||
| pset <- get_param_object(x) | |||
| if (is.null(pset)) { | |||
| rlang::abort("`autoplot()` requires objects made with tune version 0.1.0 or later.") | |||
| cli::cli_abort("{.fn autoplot} requires objects made with {.pkg tune} | |||
There was a problem hiding this comment.
Maybe time to retire this?
topepo
commented
Oct 23, 2024
simonpcouch
approved these changes
Oct 29, 2024
Co-authored-by: Simon P. Couch <simonpatrickcouch@gmail.com>
Co-authored-by: Simon P. Couch <simonpatrickcouch@gmail.com>
…nto cli-conversion
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pal was a godsend here 💯