Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tbl_sum.tbl_sql() #2749

Closed
krlmlr opened this issue May 6, 2017 · 1 comment · Fixed by tidyverse/dbplyr#14
Closed

Implement tbl_sum.tbl_sql() #2749

krlmlr opened this issue May 6, 2017 · 1 comment · Fixed by tidyverse/dbplyr#14

Comments

@krlmlr
Copy link
Member

krlmlr commented May 6, 2017

Currently, dbplyr implements print.tbl_lazy() and print.tbl_sql(), but tbl_sql objects inherit from tbl_lazy. If we remove print.tbl_sql(), printing is handled by print.tbl_lazy(), which will print only the query plan but not the data.

@hadley: Okay to get rid of print.tbl_lazy(), and implement a different method (e.g., render()) to show the query plan of a lazy object?

@hadley
Copy link
Member

hadley commented May 9, 2017

Yeah, that's fine. The function to show the query plan doesn't need to be exported for now.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants