-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use tibble::print.tbl() for printing #14
Conversation
Can you keep the extra spaces so the colons line up? |
tests/testthat/output/iris--70.txt
Outdated
|
||
# S3: tbl_dbi | ||
# A tibble : ?? x 5 | ||
# Source : table<iris-output-test> [?? x 5] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now aligning colons by adding space before them. Let me know if you prefer adding space after the colon, like in the original output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer space after colon
tests/testthat/output/iris--70.txt
Outdated
|
||
# S3: tbl_dbi | ||
# A tibble : ?? x 5 | ||
# Source : table<iris-output-test> [?? x 5] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now aligning colons by adding space before them. Let me know if you prefer adding space after the colon, like in the original output.
tests/testthat/output/iris--70.txt
Outdated
Ordered by: Sepal.Length | ||
|
||
# S3: tbl_dbi | ||
# A tibble : ?? x 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to keep this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so
@hadley: Please review
I don't have permission to merge. |
@krlmlr See tidyverse/tibble#285, |
now only need to override
tbl_sum()
. Also fixes tests.Closes tidyverse/dplyr#2749.
@hadley: Could you please review (and enable reviews for this repo)?