Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid type_sum() reexport #6058

Closed
krlmlr opened this issue Oct 25, 2021 · 3 comments
Closed

Avoid type_sum() reexport #6058

krlmlr opened this issue Oct 25, 2021 · 3 comments
Labels
breaking change ☠️ API change likely to affect existing code feature a feature request or enhancement vctrs ↗️

Comments

@krlmlr
Copy link
Member

krlmlr commented Oct 25, 2021

Users should import it from pillar (or tibble if absolutely necessary), or better implement vec_ptype_abbr() .

dplyr also reexports many more functions that are now deprecated.

This is a breaking change.

@krlmlr krlmlr changed the title Avoid type_sum() reexport Avoid type_sum() and tbl_sum() reexport Oct 25, 2021
@romainfrancois romainfrancois added this to the 1.1.0 milestone Oct 28, 2021
@hadley hadley added feature a feature request or enhancement vctrs ↗️ breaking change ☠️ API change likely to affect existing code labels Apr 16, 2022
@hadley
Copy link
Member

hadley commented Jul 22, 2022

See discussion in #6281

@DavisVaughan
Copy link
Member

To summarize, in #6284 I removed the tbl_sum() re-export, but type_sum() is imported into many other packages through dplyr and will be hard to remove #6281 (comment)

@DavisVaughan DavisVaughan changed the title Avoid type_sum() and tbl_sum() reexport Avoid type_sum() reexport Jul 22, 2022
@hadley hadley removed this from the 1.1.0 milestone Aug 18, 2022
@krlmlr
Copy link
Member Author

krlmlr commented Aug 18, 2022

Yeah, let's keep the reexport. I wish there was a way to simplify this. We could notify maintainers now, and plan for a breaking patch release (1.1.1 or 1.1.2) in a month or so from now, with just that change. But that seems so much work for so limited gain. I gave up on similar issues for pillar/tibble.

@krlmlr krlmlr closed this as not planned Won't fix, can't repro, duplicate, stale Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change ☠️ API change likely to affect existing code feature a feature request or enhancement vctrs ↗️
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants