Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid reexporting deprecated APIs #6059

Closed
wants to merge 2 commits into from

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Oct 25, 2021

For tbl_sum() and type_sum(), users can reexport from pillar or from tibble. The other functions should not be used at all.

This needs a revdepcheck.

Closes #6058.

@romainfrancois romainfrancois added the breaking change ☠️ API change likely to affect existing code label Oct 25, 2021
@romainfrancois romainfrancois added this to the 1.1.0 milestone Oct 25, 2021
@krlmlr krlmlr force-pushed the b-6058-reexport-deprecated-tibble branch from 49a6b01 to 118fd36 Compare January 30, 2022 07:14
@krlmlr krlmlr force-pushed the b-6058-reexport-deprecated-tibble branch from 118fd36 to eb5f8d8 Compare January 30, 2022 07:18
@krlmlr
Copy link
Member Author

krlmlr commented Jan 30, 2022

I initiated a revdepcheck on a version of this branch that bases directly off of v1.0.7 (#6169). Let's see if we can get a part of this into v1.0.8, it would help pillar + tibble a lot.

@krlmlr
Copy link
Member Author

krlmlr commented Jan 30, 2022

Looks like as_data_frame(), data_frame(), tbl_sum() and type_sum() are used a lot. We could remove 2-3 reexports today.

Should we e-mail the downsrteam maintainers and ask them to update within the next few months?

@DavisVaughan
Copy link
Member

I think this is a good idea, and tackled it elsewhere in individual PRs to assess how they individually affected revdeps (linked to this PR). I was able to remove lst_(), data_frame_(), frame_data(), and tbl_sum() with minimal revdep impact (3 total breakages, which I have already done PRs for). The others are still used too widely.

type_sum() in particular is used a lot, see #6281, I've started the process to move to using the pillar version in tidymodels and sparklyr.

@DavisVaughan DavisVaughan deleted the b-6058-reexport-deprecated-tibble branch May 26, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change ☠️ API change likely to affect existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid type_sum() reexport
3 participants