Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid reexporting deprecated APIs #6169

Closed
wants to merge 6 commits into from
Closed

Avoid reexporting deprecated APIs #6169

wants to merge 6 commits into from

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Jan 30, 2022

Based off of v1.0.7. Won't merge, adding revdepcheck results here.

@krlmlr krlmlr mentioned this pull request Jan 30, 2022
Closed
@krlmlr krlmlr force-pushed the b-6058-reexport-deprecated-tibble-base branch from 5d472ce to 3102094 Compare January 30, 2022 09:20
@krlmlr
Copy link
Member Author

krlmlr commented Feb 1, 2022

We can remove at least two: lst_() and frame_data() . The data_frame_() function is used only by googlesheets.

@romainfrancois romainfrancois mentioned this pull request Feb 3, 2022
Closed
@romainfrancois
Copy link
Member

Looks like this only would affect googlesheets so I've sent a pull request here: jennybc/googlesheets#403

@romainfrancois
Copy link
Member

Is this a duplicate of #6059 ?

@DavisVaughan
Copy link
Member

Duplicate of #6059

@DavisVaughan DavisVaughan marked this as a duplicate of #6059 May 26, 2022
@DavisVaughan DavisVaughan deleted the b-6058-reexport-deprecated-tibble-base branch May 26, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krlmlr @romainfrancois @DavisVaughan