-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for sf [WIP] #1990
Add support for sf [WIP] #1990
Conversation
5ffd5bc
to
155d931
Compare
Using crs recorded in coord
Improve docs
(For graticules that don't intersect with the bounding box)
# Wrapper around is.finite to handle list cols | ||
is_finite <- function(x) { | ||
if (typeof(x) == "list") { | ||
!vapply(x, is.null, logical(1)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be !vapply(x, is.finite, logical(1))
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything could be inside that list (like another list) - being finite doesn't really have a meaning for arbitrary elements so this just drops rows where the list-col is empty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh, yea, makes sense
# Conflicts: # DESCRIPTION # NEWS.md
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
No description provided.