Flip geom_curve()
direction in some circumstances
#6332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #5069.
Briefly, when reversing or flipping scales, we need to adjust the curves in
geom_curve()
to be consistent. This PR flips curves by swapping the start- and end coordinates.The approach harcodes some conditions wherein the swap needs to happen as there isn't a sensible way to derive that from the data itself. The downside of this is that a user can implement a reversing transformation with a different name and we wouldn't detect this.
Also
geom_curve()
wasn't covered by any tests, so I added some visual ones.Based on the reprexe in the linked issue; note that the curve consistently curves 'outward' (away from the panel centre).
The missing panel grid is due to #6293.
Created on 2025-02-14 with reprex v2.1.1