Fix bug in printing unsupported formats

We should be passing the pointer, not the pointer's value Fixes #1151
tidyverse · Nov 17, 2020 · 97186a8 · 97186a8
1 parent a3fc750
commit 97186a8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,7 @@
 # readr (development version)
 
+* Invalid date formats no longer can potentially crash R (#1151)
+
 # readr 1.4.0
 
 ## Breaking changes

diff --git a/src/DateTimeParser.h b/src/DateTimeParser.h
@@ -285,7 +285,7 @@ class DateTimeParser {
         break;
 
       default:
-        cpp11::stop("Unsupported format %%%s", *formatItr);
+        cpp11::stop("Unsupported format %%%s", formatItr);
       }
     }
 

diff --git a/tests/testthat/test-parsing-datetime.R b/tests/testthat/test-parsing-datetime.R
@@ -263,3 +263,7 @@ test_that("must have either two - or none", {
   expect_equal(guess_parser("200010-10"), "character")
   expect_equal(guess_parser("20001010"), "double")
 })
+
+test_that("Invalid formats error", {
+  expect_error(parse_date("2020-11-17", "%%Y-%m-%d"), "Unsupported format %%Y-%m-%d")
+})