Change path argument to file in write_csv #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The read_* and write_* functions use different parameters of file vs path, which can be confusing. Replaced path argument with file in write.R, similar to existing structure in read_delim.R. Also updated accompanying unit test in test-write.R. Results remain 759 OK / 7 Fail / 1 Warning. Fixes #964.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
read_*andwrite_*functions use different parameters offile vs path, which can be confusing. Replaced path argument with file
in
write.R, similar to existing structure inread_delim.R.Also updated accompanying unit test in
test-write.R. Resultsremain 759 OK / 7 Fail / 1 Warning.
Fixes #964.