Parsing negative numbers now returns negative values #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -100,14 +101,14 @@ inline bool parseNumber(char decimalMark, char groupingMark, Iterator& first, | |||
| break; | |||
| case STATE_FIN: | |||
| last = cur++; | |||
| res = sum; | |||
| res = negative ? sum * -1 : sum; | |||
There was a problem hiding this comment.
Could this just break so it returns using the same path as below?
There was a problem hiding this comment.
It could, I guess the only issue is it wouldn't break out of the for loop, so you would iterate through the rest of the string needlessly (probably doesn't matter).
It could be a goto though...
There was a problem hiding this comment.
Ooooh yeah. Let's leave it as is then.
jimhester
force-pushed
the
bugfix/issue308
branch
from
da19998 to
163f780
Compare
|
LGTM |
jimhester
force-pushed
the
bugfix/issue308
branch
from
163f780 to
37a897d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #308