Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read_csv2() locale issues #443

Merged
merged 3 commits into from
Jan 23, 2017
Merged

read_csv2() locale issues #443

merged 3 commits into from
Jan 23, 2017

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Jun 25, 2016

A message is provided if the locale is updated automatically by read_csv2(); if the caller passes an explict locale, it is not updated.

@hadley
Copy link
Member

hadley commented Jun 25, 2016

I think it always needs to update - but I like the message

@krlmlr
Copy link
Member Author

krlmlr commented Jun 25, 2016

Now gives message only, the message shows alternatives.

@hadley hadley added this to the 0.3.0 milestone Jul 14, 2016
@hadley
Copy link
Member

hadley commented Dec 28, 2016

LGTM

@krlmlr
Copy link
Member Author

krlmlr commented Dec 28, 2016

Thanks, rebased. I can't merge this myself.

@jimhester jimhester merged commit 727604e into tidyverse:master Jan 23, 2017
@jimhester
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@krlmlr @hadley @jimhester