Add error for overlapping fwf specification (#534). #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's great - thanks! @jimhester will do the review the details |
|
I think this looks good as is, the only thing it needs is a note in NEWS explaining the fix and mentioning the issue number and your GitHub handle. |
|
Great, thanks! |
This was referenced Feb 1, 2017
hadley
approved these changes
Feb 24, 2017
|
I merged this manually at 2513376, Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm worried that the error message part of #534 got lost in the discussion of the full implementation for overlapping columns. The previous behavior can be very difficult to track down, and I think this error message helps tremendously.
Thanks for all the great work!