-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQL's LIKE is actually case sensitive #543
Comments
@hadley I wonder whether instead of changing the default of ignore_case, what about introducing a new function: Then stringr could have two functions
I suppose the benefit of this would be that these would more directly align with SQL concepts. But the drawback would be this would be a bigger change (although perhaps a less subtle breaking change than simply switching the default) |
Yeah, I think that's a good idea. Then we can just deprecate the OTOH it's not very consistent with how other stringr handle case. But I think it's justifiable in this case because it's so closely related to mimicing SQL. |
- add str_ilike function - remove ignore_case argument from str_like - add tests of case sensitivity for both
Thanks, I'll take a look when I'm next working on stringr. |
So need to change the default, and update the docs.
Probably worth a little exploration of impact on users (with github search for
str_like()
).The text was updated successfully, but these errors were encountered: